Uploaded image for project: 'Shibboleth Discovery Service - Java'
  1. Shibboleth Discovery Service - Java
  2. SDSJ-58

default for configuration defaults to true rather than false when it is absent.

    Details

    • Type: Bug
    • Status: Closed
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 1.1.0
    • Fix Version/s: None
    • Labels:
      None
    • Java Version:
      Sun 1.6
    • Servlet Container:
      Apache Tomcat 6.0

      Description

      In DiscoveryHandler line 192 we see the following:

             String attribute = config.getAttribute("default");
              if (attribute != null && !attribute.equals("")) {
                      isDefault = Boolean.valueOf(attribute).booleanValue();
              } else {
                      isDefault = true;
              }

      That last should be isDefault = false.

      The fix to to specify a default=false into all the non default handlers.

      This may become important for misconfigured SPs which point to \DS (which is an acceptable end point) on DSs without that endpoint specified. In that case you may collect a default you didn't know was a default In the case I was testing (the UK FED DS) this was the ClearCache endpoint.

        Attachments

          Activity

            People

            • Assignee:
              rdw Rod Widdowson
              Reporter:
              rdw Rod Widdowson
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Smart Checklist