messaging routing key should be optional

 

From: Hyzer, Chris
Sent: Thursday, September 06, 2018 1:34 PM
To: 'Shilen Patel' <shilen@duke.edu>; grouper-core@internet2.edu
Subject: RE: routingKey required?

Routing key should be optional always, and can only be set for rabbitmq… I can make a patch for that.  Right Vivek?

From: grouper-core-request@internet2.edu [grouper-core-request@internet2.edu] On Behalf Of Shilen Patel
Sent: Thursday, September 06, 2018 12:57 PM
To: grouper-core@internet2.edu
Subject: [grouper-core] routingKey required?

 

I’m getting this:

 

2018-09-06 12:45:20,346: [DefaultQuartzScheduler_Worker-4] ERROR GrouperLoaderJob.runJob(485) -  - Error on job: MESSAGE_LISTENER_messagingListener

java.lang.RuntimeException: Property messaging.listener.messagingListener.routingKey in properties file: grouper-loader.properties, has a blank value, it is required

                at edu.internet2.middleware.grouperClient.config.ConfigPropertiesCascadeBase.propertyValueStringHelper(ConfigPropertiesCascadeBase.java:426)

                at edu.internet2.middleware.grouperClient.config.ConfigPropertiesCascadeBase.propertyValueString(ConfigPropertiesCascadeBase.java:361)

                at edu.internet2.middleware.grouperClient.config.ConfigPropertiesCascadeBase.propertyValueStringRequired(ConfigPropertiesCascadeBase.java:266)

                at edu.internet2.middleware.grouper.messaging.MessagingListenerController.processRecords(MessagingListenerController.java:80)

                at edu.internet2.middleware.grouper.app.loader.GrouperLoaderType$6.runJob(GrouperLoaderType.java:740)

                at edu.internet2.middleware.grouper.app.loader.GrouperLoaderJob.runJob(GrouperLoaderJob.java:465)

                at edu.internet2.middleware.grouper.app.loader.GrouperLoaderJob.execute(GrouperLoaderJob.java:345)

                at org.quartz.core.JobRunShell.run(JobRunShell.java:202)

                at org.quartz.simpl.SimpleThreadPool$WorkerThread.run(SimpleThreadPool.java:573)

The config says this:

1. note, routingKey property is valid only for rabbitmq. For other messaging systems, it is ignored.

Should it be a required property for non-rabbitmq?  Are you supposed to just put a bogus value for it?

Thanks!

• Shilen