Uploaded image for project: 'Grouper'
  1. Grouper
  2. GRP-1757

V2 links double submit, same JS imported twice

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • 2.4.0
    • 2.4.0
    • UI
    • None

    Description

      Commit 0c0ec851 from June 2017 introduced a second html script link to grouperUi.js:

       
      GRP-1489: (commit 2) Can't type multiple lines in Add Members copy/paste

      {{--- a/grouper-ui/webapp/WEB-INF/grouperUi2/assetsJsp/commonBottom.jsp
      +++ b/grouper-ui/webapp/WEB-INF/grouperUi2/assetsJsp/commonBottom.jsp
      @@ -13,6 +13,7 @@
      <script src="../../grouperExternal/public/assets/js/jquery.form.js"></script>
      <script src="../../grouperExternal/public/assets/js/grouper.js"></script>
      <script src="../../grouperExternal/public/assets/js/native.history.js"></script>
      +<script src="../../grouperExternal/public/assets/js/grouperUi.js?ver=2.4.0"></script>
      <script src="../../grouperExternal/public/assets/js/grouperUi.js"></script>
      <script src="../../grouperExternal/public/assets/js/wz_tooltip.js"></script>
      <script src="../../grouperExternal/public/assets/js/jquery.blockUI.js"></script>
      }}
       

       

      This commit in 2.3 was to change grouperUi.js to grouperUi.js?ver=2.3.0.patch.30. But the analogous one in master added without replacing, so there are two imports of identical grouperUi.js files. For whatever reason, this makes most V2 links double submit.

       

       

      Attachments

        Activity

          People

            chad.redman@at.internet2.edu Chad Redman (unc.edu)
            chad.redman@at.internet2.edu Chad Redman (unc.edu)
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: