Uploaded image for project: 'Grouper'
  1. Grouper
  2. GRP-1693

pspng throw errors on memberships of a large deleted group

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Minor
    • 2.4.0.patch
    • None
    • provisioning
    • None

    Description

      I created a loader group that had 4k members. Maybe 15 minutes later I realized I dont need this group, so I deleted it. I got 4k error emails from logging about each membership going through the changelog. Note that this group was not provisioned to pspng.

      Note: I didnt need to move the changelog pointer forward, it went through the records and logged all these erors filling up my email box.

      Maybe its a matter of not logging at ERROR level here? I assume ERRORs might be configured to email, so only log to errir if it is truly an error.

      From: Bee-Lindgren, Bert bert.bee-lindgren@oit.gatech.edu
      Sent: Thursday, February 15, 2018 2:02 PM
      To: Hyzer, Chris <mchyzer@isc.upenn.edu>; grouper-core@internet2.edu
      Subject: Re: pspng and a deleted group

      Three answers and three questions:

      • No: I would not expect any recent patches to help. This is related to GRP-1479, fixed a year ago.
      • Yes: It sounds like moving the changelog pointer forward is necessary
      • Yes: Please reopen GRP-1479 or create a new jira
      • Is there a particular reason PIT information can't be found for this group?:
        PITGroup pitGroup = PITGroupFinder.findMostRecentByName(groupName, false);
      • Can you share (in the jira) more details.

      FWIW, both the GROUP_ADD and GROUP_DELETE handling should recover smoothly from PIT-lookup failures:
      GROUP_ADD handling contains:
      if ( grouperGroupInfo == null || grouperGroupInfo.hasGroupBeenDeleted() ) {
      LOG.info("Ignoring GROUP_ADD event because group {} has been since deleted from grouper", grouperGroupInfo);
      workItem.markAsSuccess("Ignored: group does not exist any more: %s", workItem.getGroupName());
      return;

      GROUP_DELETE process contains:
      if ( grouperGroupInfo == null )

      { workItem.markAsSuccess("Ignoring group-deletion event because information was not found in grouper"); return; }

      • What type of event is the changelog bookmark stuck on?

      Thanks

      ________________________________________
      From: grouper-core-request@internet2.edu <grouper-core-request@internet2.edu> on behalf of Hyzer, Chris <mchyzer@isc.upenn.edu>
      Sent: Thursday, February 15, 2018 1:35 PM
      To: grouper-core@internet2.edu
      Subject: [grouper-core] pspng and a deleted group

      Bert,

      I created a group loaded it with 3k members. Then a little bit later, decided I don’t need it. Now Im getting a bunch of errors:

      2018-02-15 13:31:17,995: [DefaultQuartzScheduler_Worker-6] ERROR Provisioner.getGroupInfo(1208) - Unable to find PIT group 'penn:isc:ait:apps:twoFactor:groups:twoStepTempServ'

      Note, this group isn’t even provisioned by pspng…
      Is this fixed in a patch somewhere? Is the fix to stop the loader and move the change log pointer forward? Should I open a jira?

      Thanks
      Chris

      Attachments

        Issue Links

          Activity

            People

              bert.beelindgren@at.internet2.edu Bert Bee-Lindgren (gatech.edu)
              chris.hyzer@at.internet2.edu Chris Hyzer (upenn.edu)
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: